Conversation
tommasodotNET
temporarily deployed
to
azure-artifacts
GitHub Actions
Inactive
Contributor
Minimum allowed line rate is |
aaronpowell
approved these changes
Feb 17, 2025
Member
aaronpowell
left a comment
aaronpowell
left a comment
There was a problem hiding this comment.
Is it possible to create a test to cover off the bug report?
davidfowl
reviewed
Feb 17, 2025
| /// <param name="workingDirectory">The working directory for uv.</param> | ||
| public class UvAppResource(string name, string workingDirectory) | ||
| : PythonAppResource(name, "uv", workingDirectory), IResourceWithServiceDiscovery | ||
| public class UvAppResource(string name, string executablePath, string workingDirectory) |
Contributor
There was a problem hiding this comment.
This is a breaking change.
Member
There was a problem hiding this comment.
It sure is.
The uv extensions are under the umbrella of being experimental (there's an Experimental attribute on them) warning that the API is in flux.
Contributor
Author
There was a problem hiding this comment.
Sadly, to solve this I had to make the executable a var instead of hardcoding "uv". Same for uvicorn. That's because when we want to run a python app with opentelemetry, the first command of the executable has to be open-telemetry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #470
PR Checklist